-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve incomfort docs #36949
Improve incomfort docs #36949
Conversation
✅ Deploy Preview for home-assistant-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Warning Rate limit exceeded@c0ffeeca7 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 26 minutes and 13 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe pull request updates the documentation for the Changes
No sequence diagram is necessary for this documentation update, as the changes are primarily textual and do not involve changes to system interactions or control flow. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
source/_integrations/incomfort.markdown
(2 hunks)
🧰 Additional context used
🪛 LanguageTool
source/_integrations/incomfort.markdown
[grammar] ~38-~38: This phrase is duplicated. You should probably use “changing the” only once.
Context: ...erature can be changed. This similar to changing the changing the target temperature override using the C...
(PHRASE_REPETITION)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Redirect rules - home-assistant-docs
- GitHub Check: Header rules - home-assistant-docs
- GitHub Check: Pages changed - home-assistant-docs
🔇 Additional comments (2)
source/_integrations/incomfort.markdown (2)
24-24
: LGTM! Good addition of the library reference.Adding the link to the underlying client library provides valuable context for users and developers.
44-49
: LGTM! Clear and standard-compliant removal instructions.The new section follows Home Assistant documentation standards and properly includes the standard device removal template.
|
||
It uses the [incomfort](https://pypi.org/project/incomfort-client/) client library. | ||
The Intergas Lan2RF Gateway connects thermostats based on the OpenTherm standard like the [https://www.intergas-verwarming.nl/en/consumer/products/comfort-touch-thermostat/](Comfort Touch Thermostat). The thermostats and LAN2RF gateway are often sold as a set. The gateway is suitable for use with Intergas Kombi Kompakt HRE and HReco appliances from year of manufacture 2014. If the Comfort Touch thermostat together with the gateway, then this will work in combination with Intergas Kombi Kompakt HRE, HReco or Xtreme devices from year of manufacture 2017. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the markdown link syntax.
The link to the Comfort Touch Thermostat is using incorrect markdown syntax.
Apply this correction:
-[https://www.intergas-verwarming.nl/en/consumer/products/comfort-touch-thermostat/](Comfort Touch Thermostat)
+[Comfort Touch Thermostat](https://www.intergas-verwarming.nl/en/consumer/products/comfort-touch-thermostat/)
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
The Intergas Lan2RF Gateway connects thermostats based on the OpenTherm standard like the [https://www.intergas-verwarming.nl/en/consumer/products/comfort-touch-thermostat/](Comfort Touch Thermostat). The thermostats and LAN2RF gateway are often sold as a set. The gateway is suitable for use with Intergas Kombi Kompakt HRE and HReco appliances from year of manufacture 2014. If the Comfort Touch thermostat together with the gateway, then this will work in combination with Intergas Kombi Kompakt HRE, HReco or Xtreme devices from year of manufacture 2017. | |
The Intergas Lan2RF Gateway connects thermostats based on the OpenTherm standard like the [Comfort Touch Thermostat](https://www.intergas-verwarming.nl/en/consumer/products/comfort-touch-thermostat/). The thermostats and LAN2RF gateway are often sold as a set. The gateway is suitable for use with Intergas Kombi Kompakt HRE and HReco appliances from year of manufacture 2014. If the Comfort Touch thermostat together with the gateway, then this will work in combination with Intergas Kombi Kompakt HRE, HReco or Xtreme devices from year of manufacture 2017. |
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @jbouwh 👍
Proposed change
Provide a better description about the Incomfort LAN2RF gateway and how it is supported.
Instructions on how to remove the integration were added.
Type of change
current
branch).current
branch).next
branch).next
branch).Additional information
Checklist
current
branch.next
branch.Summary by CodeRabbit